Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enhance layout in Conversation components #1383

Closed
wants to merge 6 commits into from

Conversation

SamsShow
Copy link
Contributor

  • What kind of change does this PR introduce?
    fixes:

image
2)
image
4)
image

Copy link

vercel bot commented Oct 26, 2024

@SamsShow is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.83%. Comparing base (1627d42) to head (7107844).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1383      +/-   ##
==========================================
+ Coverage   33.63%   33.83%   +0.19%     
==========================================
  Files          65       67       +2     
  Lines        3297     3334      +37     
==========================================
+ Hits         1109     1128      +19     
- Misses       2188     2206      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 9:26am

Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SamsShow
Could you please check the avatar for mobile responsiveness.
image
Think it would be better if placed like the dino icon next to Answer.

@SamsShow
Copy link
Contributor Author

@ManishMadan2882
image
was working fine for a short message that's why I missed it. Will make the necessary changes

@SamsShow
Copy link
Contributor Author

@ManishMadan2882 made the changes

Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SamsShow
Sorry for not being clear before, only wanted the icon to be positioned like that on mobile screens, also the Prompt text is not required.
Just need a minor change to make the Avatar align as it was before

  • Small message
    image
  • Large message
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants